631 Commits

Author SHA1 Message Date
CanbiZ
1eb8111a28 remove debug output 2025-11-24 15:39:34 +01:00
CanbiZ
fac32e6840 Update build.func 2025-11-24 15:10:49 +01:00
CanbiZ
b2abad19ba Update build.func 2025-11-24 15:07:27 +01:00
CanbiZ
3fdb2d79c6 Normalize feature flag handling in build.func
Updated feature flag normalization to support both yes/no and 0/1 formats for ENABLE_NESTING, ENABLE_KEYCTL, and ENABLE_MKNOD. ENABLE_FUSE remains as yes/no for backward compatibility.
2025-11-24 14:59:26 +01:00
CanbiZ
99ac1ac908 Update build.func 2025-11-24 14:47:24 +01:00
CanbiZ
222bdedc25 Update build.func 2025-11-24 14:43:57 +01:00
CanbiZ
a47bc24568 Refactor PCT Options 2025-11-24 14:35:02 +01:00
CanbiZ
16c65ae73a Update build.func 2025-11-24 14:17:52 +01:00
CanbiZ
3a71045891 Update build.func 2025-11-24 14:09:29 +01:00
CanbiZ
ced1173282 Update build.func 2025-11-24 14:00:17 +01:00
CanbiZ
4613021586 Update build.func 2025-11-24 13:55:21 +01:00
CanbiZ
b529d45db0 Update build.func 2025-11-24 13:54:42 +01:00
CanbiZ
f008d4bbf9 Comment out problematic feature and dev mode code
Commented out sections related to advanced feature flags, array-based FEATURES and PCT_OPTIONS, and dev mode exports that were causing compatibility and autologin issues. Added notes and TODOs for future integration, and moved MOTD/SSH setup for debugging to only run when containers are kept for troubleshooting.
2025-11-24 13:53:48 +01:00
CanbiZ
fa82374abb Revert 2025-11-24 13:42:54 +01:00
CanbiZ
894449182d Debugcontainer build options handling
Changed PCT_OPTIONS from an array to a string for proper export and compatibility with Proxmox pct. Features are now passed as a comma-separated string. Also updated install.func to use a literal heredoc for systemd override configuration.
2025-11-24 13:34:01 +01:00
CanbiZ
b87558b415 Update build.func 2025-11-24 13:14:17 +01:00
CanbiZ
806bb715a9 Remove dev mode and log handling from build/install
Cleaned up dev mode and persistent log directory logic from build.func and install.func. Network connectivity status messages are now more direct, and unnecessary exports and re-parsing of dev_mode have been removed for clarity and maintainability.
2025-11-24 11:54:20 +01:00
CanbiZ
bea8814994 reverted 2025-11-24 11:42:00 +01:00
CanbiZ
7455f8195c Update build.func 2025-11-24 11:35:10 +01:00
CanbiZ
532fa094f3 Refactor GPU passthrough and device config handling
Switches device configuration to use pct set format for GPU passthrough, simplifying config and improving GUI visibility. Updates GID handling logic for devices, streamlines fix_gpu_gids function, and improves container creation logging and API reporting. Removes commented-out MOTD/SSH debug setup from build copy.func.
2025-11-24 10:11:13 +01:00
CanbiZ
8740271cd9 Update build.func 2025-11-24 09:48:53 +01:00
CanbiZ
f866c1cbef Add build copy.func and update build.func
Added new 'build copy.func' script for LXC container build and configuration in Proxmox VE, including variable initialization, storage management, resource allocation, and advanced interactive configuration. Updated 'build.func' to support new features and improved logic for container setup, storage selection, and app-specific defaults management.
2025-11-24 09:34:35 +01:00
CanbiZ
6a2928ca47 Update build.func 2025-11-24 09:19:34 +01:00
CanbiZ
e64957656b Quote variables in log display conditions
Added quotes around build_log_copied and install_log_copied variables in conditional checks to prevent potential issues with unbound or empty variables during log display.
2025-11-22 17:51:18 +01:00
CanbiZ
3133f47d6e Update build.func 2025-11-22 17:37:30 +01:00
CanbiZ
686e1988b3 Fix motd_ssh timing in description() - remove late post-install call 2025-11-17 17:22:54 +01:00
CanbiZ
d08d3ec424 Fix: remove debug echo from post_to_api, fix dev_index arithmetic in GPU passthrough (set -e compatible) 2025-11-17 15:44:56 +01:00
CanbiZ
68aa1df1b6 Fix GPU passthrough: use dev0/dev1 format instead of lxc.mount.entry, fix GID detection, cleanup output 2025-11-17 15:25:45 +01:00
CanbiZ
a7daaee5ae Refactor dev MOTD/SSH setup and journal cleanup
Moved MOTD/SSH setup for dev mode in LXC containers to run after installation and when containers are kept for debugging, improving reliability and clarity. Updated journalctl cleanup to avoid using $STD and suppress errors if systemd-journald is not initialized. Also refactored indentation in misc/api.func for consistency.
2025-11-17 15:09:36 +01:00
CanbiZ
b5d3293202 typo 2025-11-17 14:58:29 +01:00
CanbiZ
6e98e359d8 post 2 api + error_handling
Switches from a comma-separated FEATURES string to a FEATURES_ARRAY for proper Proxmox parameter handling. Refactors PCT_OPTIONS to an array for safer argument passing, updates container creation calls, and adds API reporting after container creation.
2025-11-17 14:56:18 +01:00
CanbiZ
2d35c9011a Normalize feature flags to numeric values in build.func
Moved normalization of feature flags (ENABLE_NESTING, ENABLE_KEYCTL, ENABLE_MKNOD, ENABLE_FUSE, PROTECT_CT) to base_settings() for consistent 0/1 values. Updated build_container() to rely on pre-normalized flags and fixed ENABLE_FUSE check. Improved pct create log file naming for uniqueness.
2025-11-17 14:41:51 +01:00
CanbiZ
414b36410d Normalize feature flags to numeric values in build.func
Updated ENABLE_NESTING, ENABLE_KEYCTL, and ENABLE_MKNOD normalization to ensure they are set to 0 or 1, as required by pct. This improves compatibility and prevents issues with non-numeric values.
2025-11-17 14:35:59 +01:00
CanbiZ
26aca1ce09 silent upgrade container 2025-11-17 14:26:32 +01:00
CanbiZ
e2179db113 Refactor MOTD/SSH setup in build script
Simplifies MOTD and SSH setup by sourcing common install functions and conditionally running motd_ssh. Improves error handling and messaging for debugging access during container initialization.
2025-11-17 14:22:48 +01:00
CanbiZ
82439d30cd Add msg_dev function for dev mode messaging
Introduces a new msg_dev function in core.func to standardize development/debugging messages. Updates build.func to use msg_dev for clearer dev mode output, replacing previous msg_custom and msg_info usages for MOTD/SSH setup and container debugging steps.
2025-11-17 14:22:22 +01:00
CanbiZ
ee5dc898f9 Update build.func 2025-11-17 14:00:52 +01:00
CanbiZ
73d6cabb52 Add advanced Proxmox container feature support
Introduces support for advanced Proxmox container features including nesting, keyctl, mknod, mount filesystems, protection flag, and timezone. Updates variable handling, settings UI, and container build logic to allow configuration and passing of these options.
2025-11-17 13:48:59 +01:00
CanbiZ
0bcd88685c Improve error handling during app installer run
Expanded comments and adjusted error handling logic when running the application installer in the container. All error traps are disabled before lxc-attach and restored after, ensuring host error_handler does not interfere with container-level error management.
2025-11-17 13:19:39 +01:00
CanbiZ
916293d98d introduce dev_mode
Introduces granular dev_mode flags (motd, keep, trace, pause, breakpoint, logs, dryrun) with a parser and exports for container builds. Enables persistent log directories when logs mode is active, supports dryrun and trace modes, and adds MOTD/SSH setup and breakpoint shell for debugging. Refactors related logic in build.func, core.func, and install.func for improved developer experience and debugging.
2025-11-17 12:53:26 +01:00
CanbiZ
c2b7f4e298 Improve container build/install logging and error handling
Introduces distinct BUILD_LOG and INSTALL_LOG variables for host and container operations, ensuring logs are properly captured and retrievable. Refactors silent execution and error handling to use the active log file, improves log copying after failures, and enhances context detection for log management. Also adds fallback logic for INSTALL_LOG initialization in install.func.
2025-11-17 12:45:24 +01:00
CanbiZ
06a4091019 Improve container install error handling and logging
Enhances reliability of application installation error detection in containers by using an error flag file, improves log copying and user prompts, and updates error handler to create a flag file with the exit code for host-side detection.
2025-11-17 12:23:51 +01:00
CanbiZ
5386da93e8 Handle failed LXC install and cleanup in build.func
Moved failed LXC installation cleanup logic from error_handler.func to build.func. Now, if installation fails, the user is prompted to remove the broken container with a 60s timeout, and the installation log is copied for debugging. Removed the cleanup_failed_lxc function and related trap from error_handler.func for better encapsulation.
2025-11-17 12:11:09 +01:00
CanbiZ
36f5e32d48 Inline explain_exit_code and clean diagnostics_check docs
Moved the explain_exit_code function directly into api.func, removing external dependency loading. Also cleaned up merge conflict markers and unified documentation for diagnostics_check in build.func.
2025-11-17 11:26:59 +01:00
CanbiZ
2f2adaea37 Merge branch 'main' of https://github.com/community-scripts/ProxmoxVED 2025-11-17 11:21:23 +01:00
CanbiZ
fc59aaede6 fix fi 2025-11-17 11:20:48 +01:00
CanbiZ
c0fc74bc9c Add detailed documentation and refactor core functions
Expanded inline documentation and section headers across misc/api.func, misc/build.func, misc/core.func, misc/error_handler.func, and misc/install.func for improved maintainability and clarity. Refactored error handling to use centralized explain_exit_code and updated API telemetry/reporting logic. Enhanced modularity and structure of utility, validation, and setup functions, and improved comments for user guidance and developer onboarding.
2025-11-17 11:17:04 +01:00
CanbiZ
432fc70e6e switch funcs 2025-11-17 10:45:28 +01:00
CanbiZ
27bb9e5192 Improve install log handling for containers
Enhances the build and error handler scripts to better manage installation logs. On install failure, the log is now copied from the container to the host for easier debugging. The error handler now saves the log inside the container's /root directory for later retrieval, improving traceability and support.
2025-11-04 17:10:28 +01:00
CanbiZ
b55e8f5f34 Improve logging and error handling with session IDs
Introduces a SESSION_ID variable for log file naming and tracking, updates log file paths to include timestamps and session IDs, and enhances error handling output to use custom message functions when available. Also improves log file management and user guidance for viewing logs, and refactors error handler to better support containerized environments.
2025-11-04 16:59:02 +01:00