From e00542a62f7c84fd35025d216c40646d5b4f9b1e Mon Sep 17 00:00:00 2001
From: Bas van den Berg <74251551+bvdberg01@users.noreply.github.com>
Date: Mon, 17 Mar 2025 12:22:10 +0100
Subject: [PATCH] Update create-discord-thread.yml

---
 .github/workflows/create-discord-thread.yml | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/create-discord-thread.yml b/.github/workflows/create-discord-thread.yml
index a84adf1..42c909a 100644
--- a/.github/workflows/create-discord-thread.yml
+++ b/.github/workflows/create-discord-thread.yml
@@ -55,7 +55,7 @@ jobs:
              JSON=$(wget -qLO - https://github.com/community-scripts/ProxmoxVED/raw/main/json/${{ env.TITLE }}.json)
              username=$(echo "$JSON" | jq -r '.default_credentials.username')
              password=$(echo "$JSON" | jq -r '.default_credentials.password')
-             notes=($(echo "$JSON" | jq -r '.notes[].text'))
+             mapfile -t notes_array < <(echo "$JSON" | jq -r '.notes[].text')
              
              if [[ -n "$username" && "$username" != "null" || -n "$password" && "$password" != "null" ]]; then
                VAR+="Default credentials:\n"
@@ -69,15 +69,13 @@ jobs:
                fi
                VAR+="\n"
              fi
-
-             if [ ${#notes[@]} -gt 0 ]; then
-               VAR+="Notes:\n"
-               for note in "${notes[@]}"; do
-                 VAR+="$note"
-               done
-               VAR+="\n"
-             fi
              
+            if [ ${#notes_array[@]} -gt 0 ]; then
+              for note in "${notes_array[@]}"; do
+                VAR+="$note\n"
+              done
+              VAR+="\n"
+            fi
           fi
           VAR+="Note: This is not in the official repo yet—it's just a dev version! After merging into ProxmoxVE, it will need to be recreated.\n\n"
           VAR+="Discussion & issue tracking:\n"