From a39f9c0095d56637161e62e28b30a29476c9b903 Mon Sep 17 00:00:00 2001 From: CrazyWolf13 Date: Mon, 8 Dec 2025 15:38:54 +0100 Subject: [PATCH 1/4] readd vars --- tools/addon/pihole-exporter.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/addon/pihole-exporter.sh b/tools/addon/pihole-exporter.sh index 1d2bfd9c6..898546d87 100644 --- a/tools/addon/pihole-exporter.sh +++ b/tools/addon/pihole-exporter.sh @@ -9,6 +9,7 @@ source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxV source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/misc/tools.func) source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/misc/build.func) + VERBOSE=${var_verbose:-no} APP="pihole-exporter" APP_TYPE="tools" From 8f5b38634976b2ee5a6b84005a62875647ef2c99 Mon Sep 17 00:00:00 2001 From: CrazyWolf13 Date: Mon, 8 Dec 2025 15:39:21 +0100 Subject: [PATCH 2/4] fix tls --- tools/addon/pihole-exporter.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/addon/pihole-exporter.sh b/tools/addon/pihole-exporter.sh index 898546d87..6010b177c 100644 --- a/tools/addon/pihole-exporter.sh +++ b/tools/addon/pihole-exporter.sh @@ -80,7 +80,7 @@ echo echo -n "Do you want to skip TLS-Verification (if using a self-signed Certificate on Pi-Hole) [y/N]: " read -er SKIP_TLS -if ! [[ "${SKIP_TLS,,}" =~ ^(y|yes)$ ]]; then +if [[ "${SKIP_TLS,,}" =~ ^(y|yes)$ ]]; then pihole_SKIP_TLS="true" fi From dc98dbdb789c569778f503bb1292abf52d4dc062 Mon Sep 17 00:00:00 2001 From: CrazyWolf13 Date: Mon, 8 Dec 2025 15:40:32 +0100 Subject: [PATCH 3/4] fix rm --- tools/addon/pihole-exporter.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/addon/pihole-exporter.sh b/tools/addon/pihole-exporter.sh index 6010b177c..bf60bc0cc 100644 --- a/tools/addon/pihole-exporter.sh +++ b/tools/addon/pihole-exporter.sh @@ -46,8 +46,7 @@ if [[ -d "$INSTALL_PATH" ]]; then rc-update del pihole-exporter &>/dev/null rm -f "$SERVICE_PATH" fi - rm -rf "$INSTALL_PATH" - rm -f "$CONFIG_PATH" ~/.pihole-exporter + rm -rf "$INSTALL_PATH" "$CONFIG_PATH" ~/.pihole-exporter msg_ok "${APP} has been uninstalled." exit 0 fi From 0020589a31b74110bad4b59386f6ad1b90917f64 Mon Sep 17 00:00:00 2001 From: CrazyWolf13 Date: Mon, 8 Dec 2025 15:54:51 +0100 Subject: [PATCH 4/4] fix --- tools/addon/pihole-exporter.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/addon/pihole-exporter.sh b/tools/addon/pihole-exporter.sh index bf60bc0cc..5547f35c5 100644 --- a/tools/addon/pihole-exporter.sh +++ b/tools/addon/pihole-exporter.sh @@ -101,7 +101,7 @@ msg_info "Creating configuration" cat <"$CONFIG_PATH" # https://github.com/eko/pihole-exporter/?tab=readme-ov-file#available-cli-options PIHOLE_PASSWORD="${pihole_PASSWORD}" -PIHOLE_hostname="${pihole_HOSTNAME}" +PIHOLE_HOSTNAME="${pihole_HOSTNAME}" SKIP_TLS_VERIFICATION="${pihole_SKIP_TLS}" EOF msg_ok "Created configuration"