From 773e748d95415570b408dfe62967987d22853bf3 Mon Sep 17 00:00:00 2001 From: juronja <101410098+juronja@users.noreply.github.com> Date: Fri, 30 Jan 2026 09:18:42 +0000 Subject: [PATCH 1/4] imported disks now have a serial ID. TrueNAS needs it. --- vm/truenas-vm.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vm/truenas-vm.sh b/vm/truenas-vm.sh index 8aee3a72e..4844527fa 100644 --- a/vm/truenas-vm.sh +++ b/vm/truenas-vm.sh @@ -539,7 +539,10 @@ if [ "$IMPORT_DISKS" == "yes" ]; then for SELECTION in $SELECTIONS; do ((++SCSI_NR)) - qm set $VMID --scsi$SCSI_NR /dev/disk/by-id/$SELECTION + + ID_SERIAL=$(echo "$SELECTION" | rev | cut -d'_' -f1 | rev) + + qm set $VMID --scsi$SCSI_NR /dev/disk/by-id/$SELECTION,serial=$ID_SERIAL done msg_ok "Disks imported successfully" fi From e43427548eb4dd184a5140ba5a6d9138f58c64b0 Mon Sep 17 00:00:00 2001 From: juronja <101410098+juronja@users.noreply.github.com> Date: Fri, 30 Jan 2026 09:31:47 +0000 Subject: [PATCH 2/4] added disk size placeholder and changed boot diks to sata --- vm/truenas-vm.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vm/truenas-vm.sh b/vm/truenas-vm.sh index 4844527fa..5e6d091e3 100644 --- a/vm/truenas-vm.sh +++ b/vm/truenas-vm.sh @@ -308,7 +308,7 @@ function advanced_settings() { exit-script fi - if DISK_SIZE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Disk Size in GiB (e.g., 10, 20)" 8 58 "$DISK_SIZE" --title "DISK SIZE" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then + if DISK_SIZE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Disk Size in GiB (e.g., 10, 20)" 8 58 16 "$DISK_SIZE" --title "DISK SIZE" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then DISK_SIZE=$(echo "$DISK_SIZE" | tr -d ' ') if [[ "$DISK_SIZE" =~ ^[0-9]+$ ]]; then echo -e "${DISKSIZE}${BOLD}${DGN}Disk Size: ${BGN}$DISK_SIZE${CL}" @@ -522,7 +522,7 @@ msg_info "Creating TrueNAS VM shell" qm create "$VMID" -machine q35 -bios ovmf -agent enabled=1 -tablet 0 -localtime 1 -cpu "$CPU_TYPE" \ -cores "$CORE_COUNT" -memory "$RAM_SIZE" -balloon 0 -name "$HN" -tags community-script \ -net0 "virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU" -onboot 1 -ostype l26 \ - -efidisk0 $STORAGE:1,efitype=4m,pre-enrolled-keys=0 -scsi0 $STORAGE:$DISK_SIZE,ssd=1,iothread=on \ + -efidisk0 $STORAGE:1,efitype=4m,pre-enrolled-keys=0 -sata0 $STORAGE:$DISK_SIZE,ssd=1,iothread=on \ -scsihw virtio-scsi-single -cdrom local:iso/$ISO_NAME -vga virtio >/dev/null msg_ok "Created VM shell" From 05416f9fe5bdc61db339209941f787d1bd2d8a30 Mon Sep 17 00:00:00 2001 From: juronja <101410098+juronja@users.noreply.github.com> Date: Fri, 30 Jan 2026 09:39:52 +0000 Subject: [PATCH 3/4] removing iothread and adding serial ID trim for robustness --- vm/truenas-vm.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vm/truenas-vm.sh b/vm/truenas-vm.sh index 5e6d091e3..d7dcf6763 100644 --- a/vm/truenas-vm.sh +++ b/vm/truenas-vm.sh @@ -522,7 +522,7 @@ msg_info "Creating TrueNAS VM shell" qm create "$VMID" -machine q35 -bios ovmf -agent enabled=1 -tablet 0 -localtime 1 -cpu "$CPU_TYPE" \ -cores "$CORE_COUNT" -memory "$RAM_SIZE" -balloon 0 -name "$HN" -tags community-script \ -net0 "virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU" -onboot 1 -ostype l26 \ - -efidisk0 $STORAGE:1,efitype=4m,pre-enrolled-keys=0 -sata0 $STORAGE:$DISK_SIZE,ssd=1,iothread=on \ + -efidisk0 $STORAGE:1,efitype=4m,pre-enrolled-keys=0 -sata0 $STORAGE:$DISK_SIZE,ssd=1 \ -scsihw virtio-scsi-single -cdrom local:iso/$ISO_NAME -vga virtio >/dev/null msg_ok "Created VM shell" @@ -541,6 +541,7 @@ if [ "$IMPORT_DISKS" == "yes" ]; then ((++SCSI_NR)) ID_SERIAL=$(echo "$SELECTION" | rev | cut -d'_' -f1 | rev) + ID_SERIAL=${ID_SERIAL:0:20} qm set $VMID --scsi$SCSI_NR /dev/disk/by-id/$SELECTION,serial=$ID_SERIAL done From 162f62daa22813b71e8b16b11486caa39f86a2c9 Mon Sep 17 00:00:00 2001 From: juronja <101410098+juronja@users.noreply.github.com> Date: Fri, 30 Jan 2026 10:07:10 +0000 Subject: [PATCH 4/4] reversed the disk placeholder size --- vm/truenas-vm.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vm/truenas-vm.sh b/vm/truenas-vm.sh index d7dcf6763..295dc6954 100644 --- a/vm/truenas-vm.sh +++ b/vm/truenas-vm.sh @@ -308,7 +308,7 @@ function advanced_settings() { exit-script fi - if DISK_SIZE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Disk Size in GiB (e.g., 10, 20)" 8 58 16 "$DISK_SIZE" --title "DISK SIZE" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then + if DISK_SIZE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Disk Size in GiB (e.g., 10, 20)" 8 58 "$DISK_SIZE" --title "DISK SIZE" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then DISK_SIZE=$(echo "$DISK_SIZE" | tr -d ' ') if [[ "$DISK_SIZE" =~ ^[0-9]+$ ]]; then echo -e "${DISKSIZE}${BOLD}${DGN}Disk Size: ${BGN}$DISK_SIZE${CL}"