From a0212eb276016247f7471139f0b242071628c30c Mon Sep 17 00:00:00 2001 From: CanbiZ <47820557+MickLesk@users.noreply.github.com> Date: Tue, 21 Oct 2025 09:50:34 +0200 Subject: [PATCH] Replace su with runuser for PostgreSQL operations Updated the setup_postgresql function to use runuser instead of su for executing pg_dumpall and psql as the postgres user. This improves compatibility and security when running these commands. --- misc/tools.func | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/misc/tools.func b/misc/tools.func index 59983a90..39061a72 100644 --- a/misc/tools.func +++ b/misc/tools.func @@ -2694,7 +2694,7 @@ function setup_postgresql() { msg_info "Installing PostgreSQL $PG_VERSION" if [[ -n "$CURRENT_PG_VERSION" ]]; then - $STD su - postgres -c "pg_dumpall > /var/lib/postgresql/backup_$(date +%F)_v${CURRENT_PG_VERSION}.sql" + $STD runuser -u postgres -- pg_dumpall > /var/lib/postgresql/backup_$(date +%F)_v${CURRENT_PG_VERSION}.sql $STD systemctl stop postgresql fi @@ -2775,7 +2775,7 @@ function setup_postgresql() { if [[ -n "$CURRENT_PG_VERSION" ]]; then $STD apt purge -y "postgresql-${CURRENT_PG_VERSION}" "postgresql-client-${CURRENT_PG_VERSION}" 2>/dev/null || true - $STD su - postgres -c "psql < /var/lib/postgresql/backup_$(date +%F)_v${CURRENT_PG_VERSION}.sql" 2>/dev/null || true + $STD runuser -u postgres -- psql < /var/lib/postgresql/backup_$(date +%F)_v${CURRENT_PG_VERSION}.sql 2>/dev/null || true fi $STD systemctl enable --now postgresql 2>/dev/null || true