Update fstrim.sh

tools/pve/fstrim.sh

@@ -12,7 +12,7 @@ function header_info() {
     _______ __                     __                    ______     _
    / ____(_) /__  _______  _______/ /____  ____ ___     /_  __/____(_)___ ___
   / /_  / / / _ \/ ___/ / / / ___/ __/ _ \/ __ `__ \     / / / ___/ / __ `__ \
- / __/ / / /  __(__  ) /_/ (__  ) /_/  __/ / / / / /    / / / /  / / / / / / /
+ / __/ / /  __(__  ) /_/ (__  ) /_/  __/ / / / / / /    / / / /  / / / / / / /
 /_/   /_/_/\___/____/\__, /____/\__/\___/_/ /_/ /_/    /_/ /_/  /_/_/ /_/ /_/
                     /____/
 EOF
@@ -27,32 +27,62 @@ CL="\033[m"
 header_info
 echo "Loading..."
 
+whiptail --backtitle "Proxmox VE Helper Scripts" \
+  --title "About fstrim (LXC)" \
+  --msgbox "The 'fstrim' command releases unused blocks back to the storage device. This only makes sense for containers on SSD, NVMe, Thin-LVM, or storage with discard/TRIM support.\n\nIf your root filesystem or container disks are on classic HDDs, thick LVM, or unsupported storage types, running fstrim will have no effect.\n\nRecommended:\n- Use fstrim only on SSD, NVMe, or thin-provisioned storage with discard enabled.\n- For ZFS, ensure 'autotrim=on' is set on your pool.\n\nSee: https://pve.proxmox.com/wiki/Shrinking_LXC_disks" 16 88
+
 ROOT_FS=$(df -Th "/" | awk 'NR==2 {print $2}')
 if [ "$ROOT_FS" != "ext4" ]; then
   whiptail --backtitle "Proxmox VE Helper Scripts" \
     --title "Warning" \
-    --yesno "Root filesystem is not ext4 ($ROOT_FS).\nContinue anyway?" 10 58 || exit 1
+    --yesno "Root filesystem is not ext4 ($ROOT_FS).\nContinue anyway?" 12 80 || exit 1
 fi
 
 NODE=$(hostname)
 EXCLUDE_MENU=()
 MSG_MAX_LENGTH=0
 
+# Build EXCLUDE_MENU for main checklist
 while read -r TAG ITEM; do
   OFFSET=2
   ((${#ITEM} + OFFSET > MSG_MAX_LENGTH)) && MSG_MAX_LENGTH=$((${#ITEM} + OFFSET))
   EXCLUDE_MENU+=("$TAG" "$ITEM " "OFF")
-done < <(pct list | awk 'NR>1')
+done < <(pct list | awk 'NR>1 {print $1, $2}')
 
 excluded_containers_raw=$(whiptail --backtitle "Proxmox VE Helper Scripts" \
   --title "Containers on $NODE" \
   --checklist "\nSelect containers to skip from trimming:\n" \
-  16 $((MSG_MAX_LENGTH + 23)) 6 "${EXCLUDE_MENU[@]}" 3>&1 1>&2 2>&3)
+  20 $((MSG_MAX_LENGTH + 32)) 10 "${EXCLUDE_MENU[@]}" 3>&1 1>&2 2>&3)
 
 [ $? -ne 0 ] && exit
 
 read -ra EXCLUDED <<<$(echo "$excluded_containers_raw" | tr -d '"')
 
+# Find all stopped containers
+STOPPED_MENU=()
+for container in $(pct list | awk 'NR>1 {print $1}'); do
+  state=$(pct status "$container" | awk '{print $2}')
+  if [[ "$state" != "running" ]]; then
+    CTNAME=$(pct config "$container" | awk -F ': ' '/^hostname:/ {print $2}')
+    STOPPED_MENU+=("$container" "$CTNAME" "OFF")
+  fi
+done
+
+TO_START=()
+if [ ${#STOPPED_MENU[@]} -gt 0 ]; then
+  selected=$(whiptail --backtitle "Proxmox VE Helper Scripts" \
+    --title "Stopped LXC Containers" \
+    --checklist "\nSome LXC containers are currently stopped.\nWhich ones do you want to temporarily start for the trim operation?\n(They will be stopped again afterwards)\n" \
+    20 80 10 "${STOPPED_MENU[@]}" 3>&1 1>&2 2>&3)
+  [ $? -ne 0 ] && exit
+  read -ra TO_START <<<$(echo "$selected" | tr -d '"')
+fi
+
+declare -A WAS_STOPPED
+for ct in "${TO_START[@]}"; do
+  WAS_STOPPED["$ct"]=1
+done
+
 function trim_container() {
   local container="$1"
   header_info
@@ -73,24 +103,48 @@ function trim_container() {
 for container in $(pct list | awk 'NR>1 {print $1}'); do
   if [[ " ${EXCLUDED[*]} " =~ " $container " ]]; then
     header_info
-    echo -e "${BL}[Info]${GN} Skipping ${BL}$container${CL}"
+    echo -e "${BL}[Info]${GN} Skipping $container (excluded)${CL}"
     sleep 0.5
     continue
   fi
   if pct config "$container" | grep -q "template:"; then
     header_info
-    echo -e "${BL}[Info]${GN} Skipping ${container} ${RD}$container is a template${CL} \n"
+    echo -e "${BL}[Info]${GN} Skipping $container (template)${CL}\n"
     sleep 0.5
     continue
   fi
   state=$(pct status "$container" | awk '{print $2}')
   if [[ "$state" != "running" ]]; then
-    header_info
-    echo -e "${BL}[Info]${GN} Skipping $container (not running)${CL}"
-    sleep 0.5
-    continue
+    if [[ -n "${WAS_STOPPED[$container]:-}" ]]; then
+      header_info
+      echo -e "${BL}[Info]${GN} Starting $container for trim...${CL}"
+      pct start "$container"
+      sleep 2
+    else
+      header_info
+      echo -e "${BL}[Info]${GN} Skipping $container (not running, not selected)${CL}"
+      sleep 0.5
+      continue
+    fi
   fi
+
   trim_container "$container"
+
+  # Optionally stop container again if we started it
+  if [[ -n "${WAS_STOPPED[$container]:-}" ]]; then
+    if whiptail --backtitle "Proxmox VE Helper Scripts" \
+      --title "Stop container again?" \
+      --yesno "Container $container was started for the trim operation.\n\nDo you want to stop it again now?" 10 60; then
+      header_info
+      echo -e "${BL}[Info]${GN} Stopping $container again...${CL}"
+      pct stop "$container"
+      sleep 1
+    else
+      header_info
+      echo -e "${BL}[Info]${GN} Leaving $container running as requested.${CL}"
+      sleep 1
+    fi
+  fi
 done
 
 header_info