Apply suggestions from code review

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This commit is contained in:
Mitch Scobell
2026-01-31 21:07:37 -06:00
committed by GitHub
parent 7cb261e774
commit 6bf2d47445
2 changed files with 6 additions and 6 deletions

View File

@@ -28,8 +28,8 @@ function update_script() {
exit exit
fi fi
msg_info "Updating ${APP}" msg_info "Updating ${APP}"
$STD apt-get update $STD apt update
$STD apt-get install --only-upgrade -y ddclient $STD apt install --only-upgrade -y ddclient
$STD systemctl restart ddclient $STD systemctl restart ddclient
msg_ok "Updated ${APP}" msg_ok "Updated ${APP}"
msg_ok "Updated successfully!" msg_ok "Updated successfully!"

View File

@@ -2,7 +2,7 @@
# Copyright (c) 2026 mitchscobell # Copyright (c) 2026 mitchscobell
# Author: mitchscobell # Author: mitchscobell
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE # License: MIT | https://github.com/community-scripts/ProxmoxVED/raw/main/LICENSE
# Source: https://ddclient.net/ # Source: https://ddclient.net/
source /dev/stdin <<<"$FUNCTIONS_FILE_PATH" source /dev/stdin <<<"$FUNCTIONS_FILE_PATH"
@@ -14,14 +14,14 @@ network_check
update_os update_os
msg_info "Installing ddclient" msg_info "Installing ddclient"
DEBIAN_FRONTEND=noninteractive $STD apt-get -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install -y ddclient DEBIAN_FRONTEND=noninteractive $STD apt -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install -y ddclient
msg_ok "Installed ddclient" msg_ok "Installed ddclient"
if [[ ! -f /etc/ddclient.conf ]]; then if [[ ! -f /etc/ddclient.conf ]]; then
msg_info "Creating sample ddclient configuration" msg_info "Creating sample ddclient configuration"
cat << 'EOF' >/etc/ddclient.conf cat << 'EOF' >/etc/ddclient.conf
# Sample ddclient.conf protocol=namecheap
# Replace with your actual settings use=web, web=dynamicdns.park-your-domain.com/getip
protocol=namecheap protocol=namecheap
use=web, web=dynamicdns.park-your-domain.com/getip use=web, web=dynamicdns.park-your-domain.com/getip
server=dynamicdns.park-your-domain.com server=dynamicdns.park-your-domain.com