community-scripts/ProxmoxVED
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Apply PR review suggestions

Browse Source 
- Remove explicit dependency installation
- Use fetch_and_deploy_gh_release helper function
- Add version checking before updates
- Use direct curl command for release version checking

Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
This commit is contained in:
Lucas Zampieri 2025-07-24 10:21:24 +01:00
parent be8392acbc
commit 259794f0a3
No known key found for this signature in database
GPG Key ID: 6DA90B962E68B074
2 changed files with 19 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
ct/cleanuparr.sh
View File

@ -27,23 +27,25 @@ function update_script() {
msg_error "No ${APP} Installation Found!" msg_error "No ${APP} Installation Found!"
exit exit
fi fi
msg_info "Stopping ${APP}"
systemctl stop cleanuparr
msg_ok "Stopped ${APP}"
msg_info "Updating ${APP}" RELEASE=$(curl -fsSL https://api.github.com/repos/Cleanuparr/Cleanuparr/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
cd /opt/cleanuparr
RELEASE=$(curl -fsSL https://api.github.com/repos/Cleanuparr/Cleanuparr/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4)}')
curl -fsSLO "https://github.com/Cleanuparr/Cleanuparr/releases/download/v${RELEASE}/Cleanuparr-${RELEASE}-linux-amd64.zip"
unzip -oq "Cleanuparr-${RELEASE}-linux-amd64.zip"
rm -f "Cleanuparr-${RELEASE}-linux-amd64.zip"
chmod +x /opt/cleanuparr/Cleanuparr
msg_ok "Updated ${APP}"
msg_info "Starting ${APP}" if [[ "${RELEASE}" != "$(cat ~/.Cleanuparr 2>/dev/null)" ]] || [[ ! -f ~/.Cleanuparr ]]; then
systemctl start cleanuparr msg_info "Stopping ${APP}"
msg_ok "Started ${APP}" systemctl stop cleanuparr
msg_ok "Updated Successfully" msg_ok "Stopped ${APP}"
msg_info "Updating ${APP} to v${RELEASE}"
fetch_and_deploy_gh_release "Cleanuparr" "Cleanuparr/Cleanuparr" "prebuild" "$RELEASE" "/opt/cleanuparr" "*linux-amd64.zip"
msg_ok "Updated ${APP}"
msg_info "Starting ${APP}"
systemctl start cleanuparr
msg_ok "Started ${APP}"
msg_ok "Updated Successfully"
else
msg_ok "No update required. ${APP} is already at v${RELEASE}"
fi
exit exit
} }
@ -54,4 +56,4 @@ description
msg_ok "Completed Successfully!\n" msg_ok "Completed Successfully!\n"
echo -e "${CREATING}${GN}${APP} setup has been successfully initialized!${CL}" echo -e "${CREATING}${GN}${APP} setup has been successfully initialized!${CL}"
echo -e "${INFO}${YW} Access it using the following URL:${CL}" echo -e "${INFO}${YW} Access it using the following URL:${CL}"
echo -e "${TAB}${GATEWAY}${BGN}http://${IP}:11011${CL}" echo -e "${TAB}${GATEWAY}${BGN}http://${IP}:11011${CL}"

16
install/cleanuparr-install.sh
View File

@ -13,22 +13,8 @@ setting_up_container
network_check network_check
update_os update_os
msg_info "Installing Dependencies"
$STD apt-get install -y \
curl \
sudo \
mc \
unzip
msg_ok "Installed Dependencies"
msg_info "Installing Cleanuparr" msg_info "Installing Cleanuparr"
RELEASE=$(curl -fsSL https://api.github.com/repos/Cleanuparr/Cleanuparr/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4)}') fetch_and_deploy_gh_release "Cleanuparr" "Cleanuparr/Cleanuparr" "prebuild" "latest" "/opt/cleanuparr" "*linux-amd64.zip"
mkdir -p /opt/cleanuparr
cd /opt/cleanuparr
curl -fsSLO "https://github.com/Cleanuparr/Cleanuparr/releases/download/v${RELEASE}/Cleanuparr-${RELEASE}-linux-amd64.zip"
unzip -q "Cleanuparr-${RELEASE}-linux-amd64.zip"
rm -f "Cleanuparr-${RELEASE}-linux-amd64.zip"
chmod +x /opt/cleanuparr/Cleanuparr
msg_ok "Installed Cleanuparr" msg_ok "Installed Cleanuparr"
msg_info "Creating Service" msg_info "Creating Service"