community-scripts/ProxmoxVED
5
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

fix: address remaining PR review feedback

Browse Source 
- Remove all section comments (beyond standardized header)
- Fix heredoc: cat <<EOF >file → cat <<EOF\n>file
- Replace apt-get with apt in cleanup
- Add missing cleanup_lxc call at end

Resolves remaining review comments from greptile-apps[bot]
This commit is contained in:
mikolaj92 2026-02-10 07:10:41 +01:00
parent ac4dab5a66
commit 0622ec6218
1 changed files with 5 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
install/calibre-web-install.sh
View File

@ -13,10 +13,6 @@ setting_up_container
network_check network_check
update_os update_os
# =============================================================================
# DEPENDENCIES - Calibre-Web requires Python and pip
# =============================================================================
msg_info "Installing Dependencies" msg_info "Installing Dependencies"
$STD apt install -y \ $STD apt install -y \
python3 \ python3 \
@ -28,44 +24,25 @@ $STD apt install -y \
fonts-liberation fonts-liberation
msg_ok "Installed Dependencies" msg_ok "Installed Dependencies"
# =============================================================================
# OPTIONAL - Install Calibre for eBook conversion
# =============================================================================
msg_info "Installing Calibre (for eBook conversion)" msg_info "Installing Calibre (for eBook conversion)"
$STD apt install -y calibre $STD apt install -y calibre
msg_ok "Installed Calibre" msg_ok "Installed Calibre"
# =============================================================================
# DOWNLOAD & DEPLOY APPLICATION
# =============================================================================
msg_info "Setting up Calibre-Web" msg_info "Setting up Calibre-Web"
fetch_and_deploy_gh_release "calibre-web" "janeczku/calibre-web" "tarball" "latest" "/opt/calibre-web" fetch_and_deploy_gh_release "calibre-web" "janeczku/calibre-web" "tarball" "latest" "/opt/calibre-web"
msg_ok "Setup Calibre-Web" msg_ok "Setup Calibre-Web"
# =============================================================================
# INSTALL PYTHON DEPENDENCIES
# =============================================================================
msg_info "Installing Python Dependencies" msg_info "Installing Python Dependencies"
cd /opt/calibre-web cd /opt/calibre-web
$STD pip3 install --no-cache-dir -r requirements.txt $STD pip3 install --no-cache-dir -r requirements.txt
msg_ok "Installed Python Dependencies" msg_ok "Installed Python Dependencies"
# =============================================================================
# CREATE DATA DIRECTORY
# =============================================================================
msg_info "Creating Data Directory" msg_info "Creating Data Directory"
mkdir -p /opt/calibre-web/data mkdir -p /opt/calibre-web/data
msg_ok "Created Data Directory" msg_ok "Created Data Directory"
# =============================================================================
# CREATE SYSTEMD SERVICE
# =============================================================================
msg_info "Creating Service" msg_info "Creating Service"
cat <<EOF >/etc/systemd/system/calibre-web.service cat <<EOF
[Unit] [Unit]
Description=Calibre-Web Service Description=Calibre-Web Service
After=network.target After=network.target
@ -84,13 +61,12 @@ EOF
systemctl enable -q --now calibre-web systemctl enable -q --now calibre-web
msg_ok "Created Service" msg_ok "Created Service"
# =============================================================================
# CLEANUP & FINALIZATION
# =============================================================================
motd_ssh motd_ssh
customize customize
msg_info "Cleaning up" msg_info "Cleaning up"
$STD apt-get -y autoremove $STD apt -y autoremove
$STD apt-get -y autoclean $STD apt -y autoclean
msg_ok "Cleaned" msg_ok "Cleaned"
cleanup_lxc