mirror of
https://github.com/community-scripts/ProxmoxVE.git
synced 2026-03-08 00:48:10 +00:00
b439960222
* fix: send telemetry BEFORE log collection in signal handlers - Swap ensure_log_on_host/post_update_to_api order in on_interrupt, on_terminate, api_exit_script, and inline SIGHUP/SIGINT/SIGTERM traps - For signal exits (>128): send telemetry immediately, then best-effort log collection - Add 2>/dev/null || true to all I/O in signal handlers to prevent SIGPIPE - Fix on_exit: exit_code=0 now reports 'done' instead of 'failed 1' - Root cause: pct pull hangs on dying containers blocked telemetry updates, leaving 595+ records stuck in 'installing' daily * feat: add execution_id to all telemetry payloads - Generate EXECUTION_ID from RANDOM_UUID in variables() - Export EXECUTION_ID to container environment - Add execution_id field to all 8 API payloads in api.func - Add execution_id to post_progress_to_api in install.func and alpine-install.func - Fallback to RANDOM_UUID when EXECUTION_ID not set (backward compat) * fix: correct telemetry type values for PVE and addon scripts - PVE scripts (tools/pve/*): change type 'tool' -> 'pve' - Addon scripts (tools/addon/*): fix 4 scripts that wrongly used 'tool' -> 'addon' (netdata, add-tailscale-lxc, add-netbird-lxc, all-templates) - api.func: post_tool_to_api sends type='pve', default fallback 'pve' - Aligns with PocketBase categories: lxc, vm, pve, addon * fix: persist diagnostics opt-in inside containers for addon telemetry - install.func + alpine-install.func: create /usr/local/community-scripts/diagnostics inside the container when DIAGNOSTICS=yes (from build.func export) - Enables addon scripts running later inside containers to find the opt-in - Update init_tool_telemetry default type from 'tool' to 'pve' * refactor: clean up diagnostics/telemetry opt-in system - diagnostics_check(): deduplicate heredoc (was 2x 22 lines), improve whiptail text with clear what/what-not collected, add telemetry + privacy links - diagnostics_menu(): better UX with current status, clear enable/disable buttons, note about existing containers - variables(): change DIAGNOSTICS default from 'yes' to 'no' (safe: no telemetry before user consents via diagnostics_check) - install.func + alpine-install.func: persist BOTH yes AND no in container so opt-out is explicit (not just missing file = no) - Fix typo 'menue' -> 'menu' in config file comments * fix: no pre-selection in telemetry dialog, link to telemetry-service README - Add --defaultno so 'No, opt out' is focused by default (user must Tab to Yes) - Change privacy link from discussions/1836 to telemetry-service#privacy--compliance * fix: use radiolist for telemetry dialog (no pre-selection) - Replace --yesno with --radiolist: user must actively SPACE-select an option - Both options start as OFF (no pre-selection) - Cancel/Exit defaults to 'no' (opt-out) * simplify: inline telemetry dialog text like other whiptail dialogs * improve: telemetry dialog with more detail, link to PRIVACY.md - Add what we collect / don't collect sections back to dialog - Link to telemetry-service/docs/PRIVACY.md instead of README anchor - Update config file comment with same link
87 lines
3.3 KiB
Bash
87 lines
3.3 KiB
Bash
#!/usr/bin/env bash
|
|
|
|
# Copyright (c) 2021-2026 community-scripts ORG
|
|
# Author: MickLesk (CanbiZ)
|
|
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
|
|
|
|
function header_info {
|
|
clear
|
|
cat <<"EOF"
|
|
____ ________ ____ __ __ __ _ ____ ___
|
|
/ __ \_________ _ ______ ___ ____ _ __ / ____/ /__ ____ _____ / __ \_________ / /_ ____ _____ ___ ____/ / / /| | / / |/ /____
|
|
/ /_/ / ___/ __ \| |/_/ __ `__ \/ __ \| |/_/ / / / / _ \/ __ `/ __ \ / / / / ___/ __ \/ __ \/ __ `/ __ \/ _ \/ __ / / / | | / / /|_/ / ___/
|
|
/ ____/ / / /_/ /> </ / / / / / /_/ /> < / /___/ / __/ /_/ / / / / / /_/ / / / /_/ / / / / /_/ / / / / __/ /_/ / / /__| |/ / / / (__ )
|
|
/_/ /_/ \____/_/|_/_/ /_/ /_/\____/_/|_| \____/_/\___/\__,_/_/ /_/ \____/_/ / .___/_/ /_/\__,_/_/ /_/\___/\__,_/ /_____/___/_/ /_/____/
|
|
/_/
|
|
EOF
|
|
}
|
|
|
|
# Telemetry
|
|
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func) 2>/dev/null || true
|
|
declare -f init_tool_telemetry &>/dev/null && init_tool_telemetry "clean-orphaned-lvm" "pve"
|
|
|
|
# Function to check for orphaned LVM volumes
|
|
function find_orphaned_lvm {
|
|
echo -e "\n🔍 Scanning for orphaned LVM volumes...\n"
|
|
|
|
orphaned_volumes=()
|
|
while read -r lv vg size seg_type; do
|
|
# Exclude system-critical LVs and Ceph OSDs
|
|
if [[ "$lv" == "data" || "$lv" == "root" || "$lv" == "swap" || "$lv" =~ ^osd-block- ]]; then
|
|
continue
|
|
fi
|
|
|
|
# Exclude thin pools (any name)
|
|
if [[ "$seg_type" == "thin-pool" ]]; then
|
|
continue
|
|
fi
|
|
|
|
container_id=$(echo "$lv" | grep -oE "[0-9]+" | head -1)
|
|
# Check if the ID exists as a VM or LXC container
|
|
if [ -f "/etc/pve/lxc/${container_id}.conf" ] || [ -f "/etc/pve/qemu-server/${container_id}.conf" ]; then
|
|
continue
|
|
fi
|
|
|
|
orphaned_volumes+=("$lv" "$vg" "$size")
|
|
done < <(lvs --noheadings -o lv_name,vg_name,lv_size,seg_type --separator ' ' 2>/dev/null | awk '{print $1, $2, $3, $4}')
|
|
|
|
# Display orphaned volumes
|
|
echo -e "❗ The following orphaned LVM volumes were found:\n"
|
|
printf "%-25s %-10s %-10s\n" "LV Name" "VG" "Size"
|
|
printf "%-25s %-10s %-10s\n" "-------------------------" "----------" "----------"
|
|
|
|
for ((i = 0; i < ${#orphaned_volumes[@]}; i += 3)); do
|
|
printf "%-25s %-10s %-10s\n" "${orphaned_volumes[i]}" "${orphaned_volumes[i + 1]}" "${orphaned_volumes[i + 2]}"
|
|
done
|
|
echo ""
|
|
}
|
|
|
|
# Function to delete selected volumes
|
|
function delete_orphaned_lvm {
|
|
for ((i = 0; i < ${#orphaned_volumes[@]}; i += 3)); do
|
|
lv="${orphaned_volumes[i]}"
|
|
vg="${orphaned_volumes[i + 1]}"
|
|
size="${orphaned_volumes[i + 2]}"
|
|
|
|
read -p "❓ Do you want to delete $lv (VG: $vg, Size: $size)? [y/N]: " confirm
|
|
if [[ "$confirm" =~ ^[Yy]$ ]]; then
|
|
echo -e "🗑️ Deleting $lv from $vg..."
|
|
lvremove -f "$vg/$lv"
|
|
if [ $? -eq 0 ]; then
|
|
echo -e "✅ Successfully deleted $lv.\n"
|
|
else
|
|
echo -e "❌ Failed to delete $lv.\n"
|
|
fi
|
|
else
|
|
echo -e "⚠️ Skipping $lv.\n"
|
|
fi
|
|
done
|
|
}
|
|
|
|
# Run script
|
|
header_info
|
|
find_orphaned_lvm
|
|
delete_orphaned_lvm
|
|
|
|
echo -e "✅ Cleanup process completed!\n"
|