From c7a1334b29cb02819f4d728df2a1eb8612ecb8ff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Slavi=C5=A1a=20Are=C5=BEina?=
 <58952836+tremor021@users.noreply.github.com>
Date: Thu, 31 Jul 2025 13:59:27 +0200
Subject: [PATCH] Refactor (#6422)

---
 ct/ombi.sh                     | 31 +++++++++++++++++++------------
 frontend/public/json/ombi.json |  2 +-
 install/ombi-install.sh        |  9 +--------
 3 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/ct/ombi.sh b/ct/ombi.sh
index 645f96930..f86e4c361 100644
--- a/ct/ombi.sh
+++ b/ct/ombi.sh
@@ -27,22 +27,29 @@ function update_script() {
     msg_error "No ${APP} Installation Found!"
     exit
   fi
-  RELEASE=$(curl -fsSL https://api.github.com/repos/Ombi-app/Ombi/releases/latest | grep '"tag_name":' | cut -d'"' -f4)
-  if [[ "${RELEASE}" != "$(cat /opt/${APP}_version.txt)" ]] || [[ ! -f /opt/${APP}_version.txt ]]; then
-    msg_info "Stopping ${APP}"
+
+  RELEASE=$(curl -fsSL https://api.github.com/repos/Ombi-app/Ombi/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
+  if [[ "${RELEASE}" != "$(cat ~/.ombi)" ]] || [[ ! -f ~/.ombi ]]; then
+    msg_info "Stopping ${APP} service"
     systemctl stop ombi
-    msg_ok "Stopped ${APP}"
+    msg_ok "Stopped ${APP} service"
 
-    msg_info "Updating ${APP} to ${RELEASE}"
-    curl -fsSL "https://github.com/Ombi-app/Ombi/releases/download/${RELEASE}/linux-x64.tar.gz" -o $(basename "https://github.com/Ombi-app/Ombi/releases/download/${RELEASE}/linux-x64.tar.gz")
-    tar -xzf linux-x64.tar.gz -C /opt/ombi
-    rm -rf linux-x64.tar.gz
-    echo "${RELEASE}" >/opt/${APP}_version.txt
-    msg_ok "Updated ${APP} to ${RELEASE}"
+    msg_info "Creating backup"
+    [[ -f /opt/ombi/Ombi.db ]] && mv /opt/ombi/Ombi.db /opt
+    [[ -f /opt/ombi/OmbiExternal.db ]] && mv /opt/ombi/OmbiExternal.db /opt
+    [[ -f /opt/ombi/OmbiSettings.db ]] && mv /opt/ombi/OmbiSettings.db /opt
+    msg_ok "Backup created"
 
-    msg_info "Starting ${APP}"
+    rm -rf /opt/ombi
+    fetch_and_deploy_gh_release "ombi" "Ombi-app/Ombi" "prebuild" "latest" "/opt/ombi" "linux-x64.tar.gz"
+    [[ -f /opt/Ombi.db ]] && mv /opt/Ombi.db /opt/ombi
+    [[ -f /opt/OmbiExternal.db ]] && mv /opt/OmbiExternal.db /opt/ombi
+    [[ -f /opt/OmbiSettings.db ]] && mv /opt/OmbiSettings.db /opt/ombi
+
+    msg_info "Starting ${APP} service"
     systemctl start ombi
-    msg_ok "Started ${APP}"
+    msg_ok "Started ${APP} service"
+
     msg_ok "Updated Successfully"
   else
     msg_ok "No update required.  ${APP} ia already at ${RELEASE}."
diff --git a/frontend/public/json/ombi.json b/frontend/public/json/ombi.json
index 1f10a7f5f..a1ab86780 100644
--- a/frontend/public/json/ombi.json
+++ b/frontend/public/json/ombi.json
@@ -6,7 +6,7 @@
   ],
   "date_created": "2024-05-02",
   "type": "ct",
-  "updateable": false,
+  "updateable": true,
   "privileged": false,
   "interface_port": 5000,
   "documentation": "https://docs.ombi.app/",
diff --git a/install/ombi-install.sh b/install/ombi-install.sh
index 87595d523..43445107a 100644
--- a/install/ombi-install.sh
+++ b/install/ombi-install.sh
@@ -13,14 +13,7 @@ setting_up_container
 network_check
 update_os
 
-msg_info "Installing Ombi"
-RELEASE=$(curl -fsSL https://api.github.com/repos/Ombi-app/Ombi/releases/latest | grep '"tag_name":' | cut -d'"' -f4)
-curl -fsSL "https://github.com/Ombi-app/Ombi/releases/download/${RELEASE}/linux-x64.tar.gz" -o "linux-x64.tar.gz"
-echo "${RELEASE}" >/opt/${APPLICATION}_version.txt
-mkdir -p /opt/ombi
-tar -xzf linux-x64.tar.gz -C /opt/ombi
-rm -rf linux-x64.tar.gz
-msg_ok "Installed Ombi"
+fetch_and_deploy_gh_release "ombi" "Ombi-app/Ombi" "prebuild" "latest" "/opt/ombi" "linux-x64.tar.gz"
 
 msg_info "Creating Service"
 cat <<EOF >/etc/systemd/system/ombi.service