mirror of
https://github.com/community-scripts/ProxmoxVE.git
synced 2026-03-03 18:15:53 +00:00
remove whiptail from update scripts for unattended update support (#11712)
* Simplify Alpine update scripts to run upgrade Remove interactive whiptail menus, loops and newt dependency checks from ct/alpine-docker.sh, ct/alpine-zigbee2mqtt.sh, and ct/alpine.sh. Each update_script now simply calls header_info, runs $STD apk -U upgrade, displays a success message and exits, simplifying and automating the update flow. * feat(update-scripts): replace whiptail with msg_menu for unattended updates Remove all whiptail dialogs from ct update_script() functions and replace with msg_menu() - a lightweight read-based menu that supports: - PHS_SILENT=1: auto-selects first (default) option for unattended mode - Interactive: numbered menu with 10s timeout and default fallback Converted scripts (whiptail menu → msg_menu): - plex.sh, npmplus.sh, cronicle.sh, meilisearch.sh, node-red.sh - homeassistant.sh, podman-homeassistant.sh - vaultwarden.sh, alpine-vaultwarden.sh - loki.sh, alpine-loki.sh - alpine-grafana.sh, alpine-redis.sh, alpine-valkey.sh - alpine-nextcloud.sh Simplified scripts (removed unnecessary whiptail for single-action updates): - alpine.sh, alpine-docker.sh, alpine-zigbee2mqtt.sh Special handling: - gitea-mirror.sh: replaced yesno/msgbox with read -rp confirmations, exit 75 in silent mode for major version upgrades requiring interaction - vaultwarden.sh/alpine-vaultwarden.sh: passwordbox replaced with read -r -s -p, skipped in silent mode with warning - nginxproxymanager.sh: exit 1 → exit 75 for disabled script Infrastructure: - Added msg_menu() helper to misc/build.func - Added exit code 75 handling in update-apps.sh (skip, not fail) Closes #11620 * refactor(update-scripts): remove menus where sequential updates suffice - alpine-nextcloud: add apk upgrade as the update action (was missing) - meilisearch: run meilisearch + UI updates sequentially (like bar-assistant) - npmplus: run alpine upgrade + docker pull sequentially, no menu - vaultwarden: update VaultWarden + Web-Vault sequentially, remove admin token option (interactive-only, not suitable for unattended updates) - alpine-vaultwarden: just run apk upgrade, remove admin token menu
This commit is contained in:
committed by
GitHub
parent
c29dfa7a29
commit
7715a02f05
@@ -3318,6 +3318,68 @@ configure_ssh_settings() {
|
||||
fi
|
||||
}
|
||||
|
||||
# ------------------------------------------------------------------------------
|
||||
# msg_menu()
|
||||
#
|
||||
# - Displays a numbered menu for update_script() functions
|
||||
# - In silent mode (PHS_SILENT=1): auto-selects the default option
|
||||
# - In interactive mode: shows menu via read with 10s timeout + default fallback
|
||||
# - Usage: CHOICE=$(msg_menu "Title" "tag1" "Description 1" "tag2" "Desc 2" ...)
|
||||
# - The first item is always the default
|
||||
# - Returns the selected tag to stdout
|
||||
# - If no valid selection or timeout, returns the default (first) tag
|
||||
# ------------------------------------------------------------------------------
|
||||
msg_menu() {
|
||||
local title="$1"
|
||||
shift
|
||||
|
||||
# Parse items into parallel arrays: tags[] and descriptions[]
|
||||
local -a tags=()
|
||||
local -a descs=()
|
||||
while [[ $# -ge 2 ]]; do
|
||||
tags+=("$1")
|
||||
descs+=("$2")
|
||||
shift 2
|
||||
done
|
||||
|
||||
local default_tag="${tags[0]}"
|
||||
local count=${#tags[@]}
|
||||
|
||||
# Silent mode: return default immediately
|
||||
if [[ -n "${PHS_SILENT+x}" ]] && [[ "${PHS_SILENT}" == "1" ]]; then
|
||||
echo "$default_tag"
|
||||
return 0
|
||||
fi
|
||||
|
||||
# Display menu
|
||||
echo ""
|
||||
msg_custom "📋" "${BL}" "${title}"
|
||||
echo ""
|
||||
for i in "${!tags[@]}"; do
|
||||
local marker=" "
|
||||
[[ $i -eq 0 ]] && marker="* "
|
||||
printf "${TAB3}${marker}%s) %s\n" "${tags[$i]}" "${descs[$i]}"
|
||||
done
|
||||
echo ""
|
||||
|
||||
local selection=""
|
||||
read -r -t 10 -p "${TAB3}Select [default=${default_tag}, timeout 10s]: " selection || true
|
||||
|
||||
# Validate selection
|
||||
if [[ -n "$selection" ]]; then
|
||||
for tag in "${tags[@]}"; do
|
||||
if [[ "$selection" == "$tag" ]]; then
|
||||
echo "$selection"
|
||||
return 0
|
||||
fi
|
||||
done
|
||||
msg_warn "Invalid selection '${selection}' - using default: ${default_tag}"
|
||||
fi
|
||||
|
||||
echo "$default_tag"
|
||||
return 0
|
||||
}
|
||||
|
||||
# ------------------------------------------------------------------------------
|
||||
# start()
|
||||
#
|
||||
|
||||
Reference in New Issue
Block a user