tools/pve: add data analytics / formatting / linting (#12034)

* core: add progress; fix exit status

Introduce post_progress_to_api() in alpine-install.func and install.func to send a lightweight, fire-and-forget telemetry ping (HTTP POST) that updates an existing telemetry record to "configuring" when DIAGNOSTICS=yes and RANDOM_UUID is set. The function is non-blocking (curl -m 5, errors ignored) and is invoked during container setup and after OS updates to signal active progress. Also adjust api_exit_script() in build.func to report success (post_update_to_api "done" "0") for cases where the script exited normally but a completion status wasn't posted, instead of reporting failure.

* Safer tools.func load and improved error handling

Replace process-substitution sourcing of tools.func with an explicit curl -> variable -> source via /dev/stdin, adding failure messages and a check that expected functions (e.g. fetch_and_deploy_gh_release) are present (misc/alpine-install.func, misc/install.func). Add categorize_error mapping for exit code 10 -> "config" (misc/api.func). Tweak build.func: minor pipeline formatting and change the ERR trap to capture the actual exit code and only call ensure_log_on_host/post_update on non-zero exits, preventing erroneous failure reporting.

* tools: add data init and auto-reporting to tools and pve section

Introduce telemetry helpers in misc/api.func: _telemetry_report_exit (reports success/failure via post_tool_to_api/post_addon_to_api) and init_tool_telemetry (reads DIAGNOSTICS, starts install timer and installs an EXIT trap to auto-report). Integrate telemetry into many tools/addon and tools/pve scripts by sourcing the remote api.func and calling init_tool_telemetry (guarded with declare -f). Also apply a minor arithmetic formatting tweak in misc/build.func for RECOVERY_ATTEMPT.

tools/pve/update-apps.sh

@@ -5,6 +5,8 @@
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
 
 source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/refs/heads/main/misc/core.func)
+source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func) 2>/dev/null || true
+declare -f init_tool_telemetry &>/dev/null && init_tool_telemetry "update-apps" "tool"
 
 # =============================================================================
 # CONFIGURATION VARIABLES
@@ -98,14 +100,14 @@ EOF
 
 # Handle command line arguments
 case "${1:-}" in
-  --help|-h)
-    print_usage
-    exit 0
-    ;;
-  --export-config)
-    export_config_json
-    exit 0
-    ;;
+--help | -h)
+  print_usage
+  exit 0
+  ;;
+--export-config)
+  export_config_json
+  exit 0
+  ;;
 esac
 
 # =============================================================================
@@ -202,40 +204,40 @@ msg_ok "Loaded ${#menu_items[@]} containers"
 # Determine container selection based on var_container
 if [[ -n "$var_container" ]]; then
   case "$var_container" in
-    all)
-      # Select all containers with matching tags
-      CHOICE=""
-      for ((i=0; i<${#menu_items[@]}; i+=3)); do
-        CHOICE="$CHOICE ${menu_items[$i]}"
-      done
-      CHOICE=$(echo "$CHOICE" | xargs)
-      ;;
-    all_running)
-      # Select only running containers with matching tags
-      CHOICE=""
-      for ((i=0; i<${#menu_items[@]}; i+=3)); do
-        cid="${menu_items[$i]}"
-        if pct status "$cid" 2>/dev/null | grep -q "running"; then
-          CHOICE="$CHOICE $cid"
-        fi
-      done
-      CHOICE=$(echo "$CHOICE" | xargs)
-      ;;
-    all_stopped)
-      # Select only stopped containers with matching tags
-      CHOICE=""
-      for ((i=0; i<${#menu_items[@]}; i+=3)); do
-        cid="${menu_items[$i]}"
-        if pct status "$cid" 2>/dev/null | grep -q "stopped"; then
-          CHOICE="$CHOICE $cid"
-        fi
-      done
-      CHOICE=$(echo "$CHOICE" | xargs)
-      ;;
-    *)
-      # Assume comma-separated list of container IDs
-      CHOICE=$(echo "$var_container" | tr ',' ' ')
-      ;;
+  all)
+    # Select all containers with matching tags
+    CHOICE=""
+    for ((i = 0; i < ${#menu_items[@]}; i += 3)); do
+      CHOICE="$CHOICE ${menu_items[$i]}"
+    done
+    CHOICE=$(echo "$CHOICE" | xargs)
+    ;;
+  all_running)
+    # Select only running containers with matching tags
+    CHOICE=""
+    for ((i = 0; i < ${#menu_items[@]}; i += 3)); do
+      cid="${menu_items[$i]}"
+      if pct status "$cid" 2>/dev/null | grep -q "running"; then
+        CHOICE="$CHOICE $cid"
+      fi
+    done
+    CHOICE=$(echo "$CHOICE" | xargs)
+    ;;
+  all_stopped)
+    # Select only stopped containers with matching tags
+    CHOICE=""
+    for ((i = 0; i < ${#menu_items[@]}; i += 3)); do
+      cid="${menu_items[$i]}"
+      if pct status "$cid" 2>/dev/null | grep -q "stopped"; then
+        CHOICE="$CHOICE $cid"
+      fi
+    done
+    CHOICE=$(echo "$CHOICE" | xargs)
+    ;;
+  *)
+    # Assume comma-separated list of container IDs
+    CHOICE=$(echo "$var_container" | tr ',' ' ')
+    ;;
   esac
 
   if [[ -z "$CHOICE" ]]; then