tools/pve: add data analytics / formatting / linting (#12034)

* core: add progress; fix exit status

Introduce post_progress_to_api() in alpine-install.func and install.func to send a lightweight, fire-and-forget telemetry ping (HTTP POST) that updates an existing telemetry record to "configuring" when DIAGNOSTICS=yes and RANDOM_UUID is set. The function is non-blocking (curl -m 5, errors ignored) and is invoked during container setup and after OS updates to signal active progress. Also adjust api_exit_script() in build.func to report success (post_update_to_api "done" "0") for cases where the script exited normally but a completion status wasn't posted, instead of reporting failure.

* Safer tools.func load and improved error handling

Replace process-substitution sourcing of tools.func with an explicit curl -> variable -> source via /dev/stdin, adding failure messages and a check that expected functions (e.g. fetch_and_deploy_gh_release) are present (misc/alpine-install.func, misc/install.func). Add categorize_error mapping for exit code 10 -> "config" (misc/api.func). Tweak build.func: minor pipeline formatting and change the ERR trap to capture the actual exit code and only call ensure_log_on_host/post_update on non-zero exits, preventing erroneous failure reporting.

* tools: add data init and auto-reporting to tools and pve section

Introduce telemetry helpers in misc/api.func: _telemetry_report_exit (reports success/failure via post_tool_to_api/post_addon_to_api) and init_tool_telemetry (reads DIAGNOSTICS, starts install timer and installs an EXIT trap to auto-report). Integrate telemetry into many tools/addon and tools/pve scripts by sourcing the remote api.func and calling init_tool_telemetry (guarded with declare -f). Also apply a minor arithmetic formatting tweak in misc/build.func for RECOVERY_ATTEMPT.

misc/api.func

@@ -985,6 +985,62 @@ get_install_duration() {
   echo $((now - INSTALL_START_TIME))
 }
 
+# ------------------------------------------------------------------------------
+# _telemetry_report_exit()
+#
+# - Internal handler called by EXIT trap set in init_tool_telemetry()
+# - Determines success/failure from exit code and reports via appropriate API
+# - Arguments:
+#   * $1: exit_code from the script
+# ------------------------------------------------------------------------------
+_telemetry_report_exit() {
+  local ec="${1:-0}"
+  local status="success"
+  [[ "$ec" -ne 0 ]] && status="failed"
+
+  # Lazy name resolution: use explicit name, fall back to $APP, then "unknown"
+  local name="${TELEMETRY_TOOL_NAME:-${APP:-unknown}}"
+
+  if [[ "${TELEMETRY_TOOL_TYPE:-tool}" == "addon" ]]; then
+    post_addon_to_api "$name" "$status" "$ec"
+  else
+    post_tool_to_api "$name" "$status" "$ec"
+  fi
+}
+
+# ------------------------------------------------------------------------------
+# init_tool_telemetry()
+#
+# - One-line telemetry setup for tools/addon scripts
+# - Reads DIAGNOSTICS from /usr/local/community-scripts/diagnostics
+# - Starts install timer for duration tracking
+# - Sets EXIT trap to automatically report success/failure on script exit
+# - Arguments:
+#   * $1: tool_name (optional, falls back to $APP at exit time)
+#   * $2: type ("tool" for PVE host scripts, "addon" for container addons)
+# - Usage:
+#   source <(curl -fsSL .../misc/api.func) 2>/dev/null || true
+#   init_tool_telemetry "post-pve-install" "tool"
+#   init_tool_telemetry "" "addon"  # uses $APP at exit time
+# ------------------------------------------------------------------------------
+init_tool_telemetry() {
+  local name="${1:-}"
+  local type="${2:-tool}"
+
+  [[ -n "$name" ]] && TELEMETRY_TOOL_NAME="$name"
+  TELEMETRY_TOOL_TYPE="$type"
+
+  # Read diagnostics opt-in/opt-out
+  if [[ -f /usr/local/community-scripts/diagnostics ]]; then
+    DIAGNOSTICS=$(grep -i "^DIAGNOSTICS=" /usr/local/community-scripts/diagnostics 2>/dev/null | awk -F'=' '{print $2}') || true
+  fi
+
+  start_install_timer
+
+  # EXIT trap: automatically report telemetry when script ends
+  trap '_telemetry_report_exit "$?"' EXIT
+}
+
 # ------------------------------------------------------------------------------
 # post_tool_to_api()
 #

misc/build.func

@@ -4431,7 +4431,7 @@ EOF'
           export var_cpu="$CORE_COUNT"
           export VERBOSE="yes"
           export var_verbose="yes"
-          export RECOVERY_ATTEMPT=$(( ${RECOVERY_ATTEMPT:-0} + 1 ))
+          export RECOVERY_ATTEMPT=$((${RECOVERY_ATTEMPT:-0} + 1))
 
           echo -e "${YW}Rebuilding with increased resources (attempt ${RECOVERY_ATTEMPT}/2):${CL}"
           echo -e "  Container ID: ${old_ctid} → ${CTID}"