From 327cb37a55c8c7adbf6525ec184aa59b51ee8584 Mon Sep 17 00:00:00 2001
From: Parker Shankin-Clarke <38367844+pshankinclarke@users.noreply.github.com>
Date: Tue, 2 Dec 2025 00:50:48 -0800
Subject: [PATCH] Add auth via requirepass to Valkey (#9570)

* Add auth via requirepass to Valkey

* Refactor notes in valkey.json for clarity

Updated notes structure to include detailed login instructions.

* Remove password saving message from installation script

Removed message indicating Valkey password saving.

* Fix JSON syntax error in valkey.json

* Update valkey.json

* refactor

---------

Co-authored-by: CanbiZ <47820557+MickLesk@users.noreply.github.com>
Co-authored-by: Tobias <96661824+CrazyWolf13@users.noreply.github.com>
---
 frontend/public/json/valkey.json | 7 ++++++-
 install/valkey-install.sh        | 6 +++++-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/frontend/public/json/valkey.json b/frontend/public/json/valkey.json
index f94e6b9a0..91149fb42 100644
--- a/frontend/public/json/valkey.json
+++ b/frontend/public/json/valkey.json
@@ -31,5 +31,10 @@
     "username": null,
     "password": null
   },
-  "notes": []
+  "notes": [
+    {
+      "text": "Show Login Credentials, type `cat ~/valkey.creds` in the LXC console",
+      "type": "info"
+    }
+  ]
 }
diff --git a/install/valkey-install.sh b/install/valkey-install.sh
index 6a0a1441f..3d1be73fb 100644
--- a/install/valkey-install.sh
+++ b/install/valkey-install.sh
@@ -15,8 +15,12 @@ update_os
 
 msg_info "Installing Valkey"
 $STD apt update
-$STD apt install -y valkey
+$STD apt install -y valkey openssl
 sed -i 's/^bind .*/bind 0.0.0.0/' /etc/valkey/valkey.conf
+PASS="$(openssl rand -base64 48 | tr -dc 'a-zA-Z0-9' | head -c32)"
+echo "requirepass $PASS" >> /etc/valkey/valkey.conf
+echo "$PASS" >~/valkey.creds
+chmod 600 ~/valkey.creds
 systemctl enable -q --now valkey-server
 systemctl restart valkey-server
 msg_ok "Installed Valkey"